Patchew URL: https://patchew.org/QEMU/20190625050008.12789-1-ehabk...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190625050008.12789-1-ehabk...@redhat.com Type: series Subject: [Qemu-devel] [PATCH 0/6] x86 CPU model versioning === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu * [new tag] patchew/20190625050008.12789-1-ehabk...@redhat.com -> patchew/20190625050008.12789-1-ehabk...@redhat.com Switched to a new branch 'test' fa60fbbfe4 i386: Add Cascadelake-Server-4.1.1 CPU model 41aac3f41c docs: Deprecate CPU model runnability guarantees 7702d3e8ca i386: Infrastructure for versioned CPU models 3fe33acf1b qmp: Add "alias-of" field to query-cpu-definitions 582f02c5f5 i386: Remove unused host_cpudef variable be6cf76099 i386: Add x-force-features option for testing === OUTPUT BEGIN === 1/6 Checking commit be6cf760996c (i386: Add x-force-features option for testing) 2/6 Checking commit 582f02c5f580 (i386: Remove unused host_cpudef variable) 3/6 Checking commit 3fe33acf1b30 (qmp: Add "alias-of" field to query-cpu-definitions) 4/6 Checking commit 7702d3e8ca63 (i386: Infrastructure for versioned CPU models) WARNING: Block comments use a leading /* on a separate line #212: FILE: target/i386/cpu.c:3075: + { /* end of list */ }, WARNING: line over 80 characters #261: FILE: target/i386/cpu.c:3987: +static const X86CPUVersionDefinition *x86_cpu_def_get_versions(X86CPUDefinition *def) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #457: new file mode 100644 WARNING: line over 80 characters #507: FILE: tests/acceptance/x86_cpu_model_versions.py:46: + cpus = dict((m['name'], m) for m in self.vm.command('query-cpu-definitions')) WARNING: line over 80 characters #510: FILE: tests/acceptance/x86_cpu_model_versions.py:49: + 'unversioned Cascadelake-Server CPU model must not be static') WARNING: line over 80 characters #527: FILE: tests/acceptance/x86_cpu_model_versions.py:66: + cpus = dict((m['name'], m) for m in self.vm.command('query-cpu-definitions')) WARNING: line over 80 characters #530: FILE: tests/acceptance/x86_cpu_model_versions.py:69: + 'unversioned Cascadelake-Server CPU model must not be static') ERROR: line over 90 characters #531: FILE: tests/acceptance/x86_cpu_model_versions.py:70: + self.assertEquals(cpus['Cascadelake-Server'].get('alias-of'), 'Cascadelake-Server-4.1', WARNING: line over 80 characters #532: FILE: tests/acceptance/x86_cpu_model_versions.py:71: + 'Cascadelake-Server must be an alias of Cascadelake-Server-4.1') WARNING: line over 80 characters #549: FILE: tests/acceptance/x86_cpu_model_versions.py:88: + cpus = dict((m['name'], m) for m in self.vm.command('query-cpu-definitions')) WARNING: line over 80 characters #552: FILE: tests/acceptance/x86_cpu_model_versions.py:91: + 'unversioned Cascadelake-Server CPU model must not be static') ERROR: line over 90 characters #553: FILE: tests/acceptance/x86_cpu_model_versions.py:92: + self.assertTrue(cpus['Cascadelake-Server']['alias-of'].startswith('Cascadelake-Server-'), WARNING: line over 80 characters #554: FILE: tests/acceptance/x86_cpu_model_versions.py:93: + 'Cascadelake-Server must be an alias of versioned CPU model') total: 2 errors, 11 warnings, 477 lines checked Patch 4/6 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/6 Checking commit 41aac3f41c03 (docs: Deprecate CPU model runnability guarantees) 6/6 Checking commit fa60fbbfe411 (i386: Add Cascadelake-Server-4.1.1 CPU model) WARNING: Block comments use a leading /* on a separate line #43: FILE: target/i386/cpu.c:2620: + { /* end of list */ }, WARNING: Block comments use a leading /* on a separate line #46: FILE: target/i386/cpu.c:2623: + { /* end of list */ }, ERROR: line over 90 characters #74: FILE: tests/acceptance/x86_cpu_model_versions.py:111: + vm.add_args('-cpu', 'Cascadelake-Server,x-force-features=on,check=off,enforce=off') ERROR: line over 90 characters #77: FILE: tests/acceptance/x86_cpu_model_versions.py:114: + 'pc-i440fx-4.1 + Cascadelake-Server should not have arch-capabilities') ERROR: line over 90 characters #82: FILE: tests/acceptance/x86_cpu_model_versions.py:119: + vm.add_args('-cpu', 'Cascadelake-Server,x-force-features=on,check=off,enforce=off') ERROR: line over 90 characters #85: FILE: tests/acceptance/x86_cpu_model_versions.py:122: + 'pc-i440fx-4.0 + Cascadelake-Server should not have arch-capabilities') ERROR: line over 90 characters #91: FILE: tests/acceptance/x86_cpu_model_versions.py:128: + vm.add_args('-cpu', 'Cascadelake-Server,x-force-features=on,check=off,enforce=off,+arch-capabilities') ERROR: line over 90 characters #94: FILE: tests/acceptance/x86_cpu_model_versions.py:131: + 'pc-i440fx-4.0 + Cascadelake-Server,+arch-capabilities should have arch-capabilities') ERROR: line over 90 characters #99: FILE: tests/acceptance/x86_cpu_model_versions.py:136: + vm.add_args('-cpu', 'Cascadelake-Server,x-force-features=on,check=off,enforce=off,-arch-capabilities') ERROR: line over 90 characters #102: FILE: tests/acceptance/x86_cpu_model_versions.py:139: + 'pc-i440fx-4.1 + Cascadelake-Server,-arch-capabilities should not have arch-capabilities') ERROR: line over 90 characters #108: FILE: tests/acceptance/x86_cpu_model_versions.py:145: + vm.add_args('-cpu', 'Cascadelake-Server-4.1,x-force-features=on,check=off,enforce=off') ERROR: line over 90 characters #111: FILE: tests/acceptance/x86_cpu_model_versions.py:148: + 'pc-i440fx-4.1 + Cascadelake-Server-4.1 should not have arch-capabilities') ERROR: line over 90 characters #116: FILE: tests/acceptance/x86_cpu_model_versions.py:153: + vm.add_args('-cpu', 'Cascadelake-Server-4.1.1,x-force-features=on,check=off,enforce=off') ERROR: line over 90 characters #119: FILE: tests/acceptance/x86_cpu_model_versions.py:156: + 'pc-i440fx-4.1 + Cascadelake-Server-4.1 should have arch-capabilities') ERROR: line over 90 characters #125: FILE: tests/acceptance/x86_cpu_model_versions.py:162: + vm.add_args('-cpu', 'Cascadelake-Server,x-force-features=on,check=off,enforce=off,+arch-capabilities') ERROR: line over 90 characters #128: FILE: tests/acceptance/x86_cpu_model_versions.py:165: + 'pc-i440fx-4.0 + Cascadelake-Server-4.1,+arch-capabilities should have arch-capabilities') ERROR: line over 90 characters #133: FILE: tests/acceptance/x86_cpu_model_versions.py:170: + vm.add_args('-cpu', 'Cascadelake-Server-4.1.1,x-force-features=on,check=off,enforce=off,-arch-capabilities') ERROR: line over 90 characters #136: FILE: tests/acceptance/x86_cpu_model_versions.py:173: + 'pc-i440fx-4.1 + Cascadelake-Server-4.1.1,-arch-capabilities should not have arch-capabilities') total: 16 errors, 2 warnings, 101 lines checked Patch 6/6 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190625050008.12789-1-ehabk...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
