On 3/21/19 3:23 AM, Thomas Huth wrote: > pipelines in that case. I had to manually select the test cases in the > .gitlab-ci.yml file due to this. I don't mind too much, but IMHO "make > check-block" should simply run everywhere, with every QEMU binary, and > not only if you've compiled it with the right options and/or KVM is > available. Otherwise, we maybe need a "make check-block-simple" or "make > check-block-ci" target, that uses another new group beside the "quick" > group? I.e. introduce a "ci" or "simple" group into
I don't know how to tell '-g quick' apart from '-g simple', but having a '-g ci' where we can add or remove tests from ci by editing qemu-iotests/group seems reasonable. Then switching 'make check-block' to prefer -g ci makes sense, while developers wanting a bit more coverage without long waits can still rely on -g quick. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
