On 3/12/19 2:51 PM, Unai Martinez-Corral wrote: > This patch breaks backward compatibility. >
Is it worth a mention why we don't consider backwards-compatibility for this script to be very important? > Both '--persistent' and '--credential' default to 'no'. Hence, '-p no' > or '-c no' are reduntant. Overall, accepting an argument might be redundant (Maintainer could fix up the typo without you needing to send v8, if the only thing I find are minor like that) > misleading because options are, indeed, boolean. This patch makes both > options boolean in getopt, so if any of them is provided the corresponding > variable is set to true. > > Signed-off-by: Unai Martinez-Corral <unai.martinezcor...@ehu.eus> > Reviewed-by: Laurent Vivier <laur...@vivier.eu> > --- > scripts/qemu-binfmt-conf.sh | 16 +++++++--------- > 1 file changed, 7 insertions(+), 9 deletions(-) > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
