Patchew URL: https://patchew.org/QEMU/20190312195009.GA6@99bbefa4bcea/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190312195009.GA6@99bbefa4bcea Subject: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190312195009.GA6@99bbefa4bcea -> patchew/20190312195009.GA6@99bbefa4bcea Switched to a new branch 'test' db00757392 qemu-binfmt-conf.sh: add --test d9371a760a qemu-binfmt-conf.sh: add option --clear 3e38998afe qemu-binfmt-conf.sh: generalize <CPU> to positional TARGETS c05e91d1d2 qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX e5c54cc358 qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options 443291983a qemu-binfmt-conf.sh: use the same presentation format as for qemu-* b979bcce07 qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT d02fe8d3da qemu-binfmt-conf.sh: make opts -p and -c boolean a8c25771ea qemu-binfmt-conf.sh: enforce safe style consistency === OUTPUT BEGIN === 1/9 Checking commit a8c25771ea74 (qemu-binfmt-conf.sh: enforce safe style consistency) WARNING: line over 80 characters #53: FILE: scripts/qemu-binfmt-conf.sh:299: + if [ "x$magic" = "x" ] || [ "x$mask" = "x" ] || [ "x$family" = "x" ] ; then total: 0 errors, 1 warnings, 47 lines checked Patch 1/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/9 Checking commit d02fe8d3daab (qemu-binfmt-conf.sh: make opts -p and -c boolean) ERROR: line over 90 characters #51: FILE: scripts/qemu-binfmt-conf.sh:327: +options=$(getopt -o ds:Q:S:e:hcp -l debian,systemd:,qemu-path:,qemu-suffix:,exportdir:,help,credential,persistent -- "$@") total: 1 errors, 0 warnings, 43 lines checked Patch 2/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/9 Checking commit b979bcce0795 (qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT) 4/9 Checking commit 443291983a5d (qemu-binfmt-conf.sh: use the same presentation format as for qemu-*) WARNING: line over 80 characters #50: FILE: scripts/qemu-binfmt-conf.sh:179: +-F|--qemu-suffix SUFFIX add a suffix to the default interpreter name ERROR: line over 90 characters #51: FILE: scripts/qemu-binfmt-conf.sh:180: +-p|--persistent QEMU_PERSISTENT (yes) load the interpreter and keep it in memory; all future ERROR: line over 90 characters #53: FILE: scripts/qemu-binfmt-conf.sh:182: +-c|--credential QEMU_CREDENTIAL (yes) credential and security tokens are calculated according ERROR: line over 90 characters #58: FILE: scripts/qemu-binfmt-conf.sh:187: + systemd-binfmt.service for the given CPU; if CPU is "ALL", ERROR: line over 90 characters #60: FILE: scripts/qemu-binfmt-conf.sh:189: +-d|--debian don't write into /proc, generate update-binfmts templates ERROR: line over 90 characters #85: FILE: scripts/qemu-binfmt-conf.sh:206: +The environment variable HOST_ARCH allows to override 'uname' to generate configuration files for a total: 5 errors, 1 warnings, 79 lines checked Patch 4/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/9 Checking commit e5c54cc358b8 (qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options) WARNING: line over 80 characters #36: FILE: scripts/qemu-binfmt-conf.sh:180: +-F|--suffix SUFFIX add a suffix to the default interpreter name ERROR: line over 90 characters #45: FILE: scripts/qemu-binfmt-conf.sh:333: +options=$(getopt -o ds:Q:S:e:hcp -l debian,systemd:,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 1 errors, 1 warnings, 38 lines checked Patch 5/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/9 Checking commit c05e91d1d23d (qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX) WARNING: line over 80 characters #23: FILE: scripts/qemu-binfmt-conf.sh:180: +-F|--suffix SUFFIX QEMU_SUFFIX add a suffix to the default interpreter name total: 0 errors, 1 warnings, 30 lines checked Patch 6/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/9 Checking commit 3e38998afeae (qemu-binfmt-conf.sh: generalize <CPU> to positional TARGETS) ERROR: line over 90 characters #77: FILE: scripts/qemu-binfmt-conf.sh:199: +TARGETS QEMU_TARGETS A single arch name or a list of them (see all names below); WARNING: line over 80 characters #90: FILE: scripts/qemu-binfmt-conf.sh:211: +-s|--systemd don't write into /proc, generate file(s) for ERROR: line over 90 characters #104: FILE: scripts/qemu-binfmt-conf.sh:230: +The environment variable HOST_ARCH allows to override 'uname' to generate configuration files for ERROR: line over 90 characters #146: FILE: scripts/qemu-binfmt-conf.sh:359: +options=$(getopt -o dsQ:S:e:hcp -l debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 3 errors, 1 warnings, 141 lines checked Patch 7/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/9 Checking commit d9371a760a47 (qemu-binfmt-conf.sh: add option --clear) WARNING: line over 80 characters #33: FILE: scripts/qemu-binfmt-conf.sh:200: + if empty, configure/clear all known targets; ERROR: line over 90 characters #41: FILE: scripts/qemu-binfmt-conf.sh:209: +-r|--clear QEMU_CLEAR (yes) remove registered interpreters for target TARGETS; ERROR: line over 90 characters #84: FILE: scripts/qemu-binfmt-conf.sh:377: +options=$(getopt -o rdsQ:S:e:hcp -l clear,debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 2 errors, 1 warnings, 85 lines checked Patch 8/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/9 Checking commit db0075739279 (qemu-binfmt-conf.sh: add --test) WARNING: line over 80 characters #20: FILE: scripts/qemu-binfmt-conf.sh:200: + if empty, configure/clear all known targets. ERROR: line over 90 characters #28: FILE: scripts/qemu-binfmt-conf.sh:210: +-t|--test QEMU_TEST (yes) test the setup with the provided arguments, but do not ERROR: line over 90 characters #58: FILE: scripts/qemu-binfmt-conf.sh:377: +options=$(getopt -o trdsQ:S:e:hcp -l test,clear,debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 2 errors, 1 warnings, 61 lines checked Patch 9/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190312195009.GA6@99bbefa4bcea/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
