i hope you don't find this offensive, Eric but i'm forwarding this message to all the people on this thread.
i don't find anything exactly private in this email. [off-list] On 3/4/19 1:20 PM, David Kiarie wrote: > On Mon, Mar 4, 2019 at 8:48 PM Philippe Mathieu-Daudé <phi...@redhat.com> > wrote: > >> On 3/4/19 4:18 PM, David Kiarie wrote: >>> Signed-off-by: David Kiarie <davidkiar...@gmail.com> >> >> Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> >> > > would i be wrong to say this patch received unwarranted scrutiny from you, > Philippe? David, please calm down, and don't write emails that can sound like you are attacking your reviewers on list. Assume good intent - Philippe reviewed your patch with the same level of scrutiny as many other patches he reviews, and his question for your previous patch revision about whether you intended to change the copyright year was not an attack, but an honest question. Open source works best when anyone feels like they can contribute. Copyright lines are an interesting beast - they carry legal significance, so care should be taken that they aren't changed by mistake, but at the same time, you do not have to know the code that the copyright is protecting to ask an honest question about whether a change is intentional. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org