Hi David, On 3/4/19 8:29 PM, David Kiarie wrote: > > > On Mon, Mar 4, 2019 at 10:20 PM David Kiarie <davidkiar...@gmail.com > <mailto:davidkiar...@gmail.com>> wrote: > > > > On Mon, Mar 4, 2019 at 8:48 PM Philippe Mathieu-Daudé > <phi...@redhat.com <mailto:phi...@redhat.com>> wrote: > > On 3/4/19 4:18 PM, David Kiarie wrote: > > Signed-off-by: David Kiarie <davidkiar...@gmail.com > <mailto:davidkiar...@gmail.com>> > > Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com > <mailto:phi...@redhat.com>> > > > would i be wrong to say this patch received unwarranted scrutiny > from you, Philippe? > > > i mean, given you have never been involved in any IOMMU work, i wouldn't > expect that you're in a position to asking questions about the copyright.
IANAL and I have no knowledge of IOMMU indeed. I noticed first this patch is sent from the same email used in this copyright notice, then the patch content merged in commit d29a09ca684 was accepted in 2016 with a copyright date of 2015, hence your copyright modification looks correct to me. Regards, Philippe. > > > > > > --- > > hw/i386/amd_iommu.c | 2 +- > > hw/i386/amd_iommu.h | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c > > index 8ad707a..6eabdf9 100644 > > --- a/hw/i386/amd_iommu.c > > +++ b/hw/i386/amd_iommu.c > > @@ -2,7 +2,7 @@ > > * QEMU emulation of AMD IOMMU (AMD-Vi) > > * > > * Copyright (C) 2011 Eduard - Gabriel Munteanu > > - * Copyright (C) 2015 David Kiarie, <davidkiar...@gmail.com > <mailto:davidkiar...@gmail.com>> > > + * Copyright (C) 2015, 2016 David Kiarie Kahurani > > * > > * This program is free software; you can redistribute it > and/or modify > > * it under the terms of the GNU General Public License as > published by > > diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h > > index c52886f..0ff9095 100644 > > --- a/hw/i386/amd_iommu.h > > +++ b/hw/i386/amd_iommu.h > > @@ -2,7 +2,7 @@ > > * QEMU emulation of an AMD IOMMU (AMD-Vi) > > * > > * Copyright (C) 2011 Eduard - Gabriel Munteanu > > - * Copyright (C) 2015 David Kiarie, <davidkiar...@gmail.com > <mailto:davidkiar...@gmail.com>> > > + * Copyright (C) 2015, 2016 David Kiarie Kahurani > > * > > * This program is free software; you can redistribute it > and/or modify > > * it under the terms of the GNU General Public License as > published by > > >
