Patchew URL: https://patchew.org/QEMU/20190215192302.27855-1-richard.hender...@linaro.org/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190215192302.27855-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH v4 0/8] target/arm: Implement ARMv8.3-JSConv & ARMv8.2-FHM Type: series === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190215192302.27855-1-richard.hender...@linaro.org -> patchew/20190215192302.27855-1-richard.hender...@linaro.org Switched to a new branch 'test' 0ff65a844d target/arm: Enable ARMv8.2-FHM for -cpu max ad1df52ee0 target/arm: Implement VFMAL and VFMSL for aarch32 5f63a9cb31 target/arm: Implement FMLAL and FMLSL for aarch64 b188cbbcba target/arm: Add helpers for FMLAL e6e668123e target/arm: Implement ARMv8.3-JSConv 0234b531fe target/arm: Rearrange Floating-point data-processing (2 regs) 04c91ee51e target/arm: Split out vfp_helper.c 037d4059a2 target/arm: Restructure disas_fp_int_conv === OUTPUT BEGIN === 1/8 Checking commit 037d4059a225 (target/arm: Restructure disas_fp_int_conv) 2/8 Checking commit 04c91ee51e3c (target/arm: Split out vfp_helper.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #1102: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #1134: FILE: target/arm/vfp_helper.c:28: +/* VFP support. We follow the convention used for VFP instructions: WARNING: Block comments use * on subsequent lines #1135: FILE: target/arm/vfp_helper.c:29: +/* VFP support. We follow the convention used for VFP instructions: + Single precision routines have a "s" suffix, double precision a WARNING: Block comments use a trailing */ on a separate line #1136: FILE: target/arm/vfp_helper.c:30: + "d" suffix. */ ERROR: braces {} are necessary for all arms of this statement #1143: FILE: target/arm/vfp_helper.c:37: + if (host_bits & float_flag_invalid) [...] ERROR: braces {} are necessary for all arms of this statement #1145: FILE: target/arm/vfp_helper.c:39: + if (host_bits & float_flag_divbyzero) [...] ERROR: braces {} are necessary for all arms of this statement #1147: FILE: target/arm/vfp_helper.c:41: + if (host_bits & float_flag_overflow) [...] ERROR: braces {} are necessary for all arms of this statement #1149: FILE: target/arm/vfp_helper.c:43: + if (host_bits & (float_flag_underflow | float_flag_output_denormal)) [...] ERROR: braces {} are necessary for all arms of this statement #1151: FILE: target/arm/vfp_helper.c:45: + if (host_bits & float_flag_inexact) [...] ERROR: braces {} are necessary for all arms of this statement #1153: FILE: target/arm/vfp_helper.c:47: + if (host_bits & float_flag_input_denormal) [...] ERROR: braces {} are necessary for all arms of this statement #1189: FILE: target/arm/vfp_helper.c:83: + if (target_bits & 1) [...] ERROR: braces {} are necessary for all arms of this statement #1191: FILE: target/arm/vfp_helper.c:85: + if (target_bits & 2) [...] ERROR: braces {} are necessary for all arms of this statement #1193: FILE: target/arm/vfp_helper.c:87: + if (target_bits & 4) [...] ERROR: braces {} are necessary for all arms of this statement #1195: FILE: target/arm/vfp_helper.c:89: + if (target_bits & 8) [...] ERROR: braces {} are necessary for all arms of this statement #1197: FILE: target/arm/vfp_helper.c:91: + if (target_bits & 0x10) [...] ERROR: braces {} are necessary for all arms of this statement #1199: FILE: target/arm/vfp_helper.c:93: + if (target_bits & 0x80) [...] WARNING: Block comments use a leading /* on a separate line #1271: FILE: target/arm/vfp_helper.c:165: + /* The exception flags are ORed together when we read fpscr so we ERROR: space required after that ',' (ctx:VxV) #1286: FILE: target/arm/vfp_helper.c:180: +#define VFP_HELPER(name, p) HELPER(glue(glue(vfp_,name),p)) ^ ERROR: space required after that ',' (ctx:VxV) #1286: FILE: target/arm/vfp_helper.c:180: +#define VFP_HELPER(name, p) HELPER(glue(glue(vfp_,name),p)) ^ ERROR: Macros with multiple statements should be enclosed in a do - while loop #1288: FILE: target/arm/vfp_helper.c:182: +#define VFP_BINOP(name) \ +float32 VFP_HELPER(name, s)(float32 a, float32 b, void *fpstp) \ +{ \ + float_status *fpst = fpstp; \ + return float32_ ## name(a, b, fpst); \ +} \ +float64 VFP_HELPER(name, d)(float64 a, float64 b, void *fpstp) \ +{ \ + float_status *fpst = fpstp; \ + return float64_ ## name(a, b, fpst); \ +} ERROR: space prohibited before that close parenthesis ')' #1400: FILE: target/arm/vfp_helper.c:294: + CONV_FTOI(vfp_to##name##p, ftype, fsz, sign, ) \ ERROR: space prohibited before that close parenthesis ')' #1403: FILE: target/arm/vfp_helper.c:297: +FLOAT_CONVS(si, h, uint32_t, 16, ) ERROR: space prohibited before that close parenthesis ')' #1404: FILE: target/arm/vfp_helper.c:298: +FLOAT_CONVS(si, s, float32, 32, ) ERROR: space prohibited before that close parenthesis ')' #1405: FILE: target/arm/vfp_helper.c:299: +FLOAT_CONVS(si, d, float64, 64, ) ERROR: space prohibited before that close parenthesis ')' #1447: FILE: target/arm/vfp_helper.c:341: + get_float_rounding_mode(fpst), ) ERROR: space prohibited before that close parenthesis ')' #1452: FILE: target/arm/vfp_helper.c:346: + get_float_rounding_mode(fpst), ) WARNING: Block comments use a leading /* on a separate line #1552: FILE: target/arm/vfp_helper.c:446: +/* Set the current fp rounding mode and return the old one. WARNING: Block comments use a leading /* on a separate line #1565: FILE: target/arm/vfp_helper.c:459: +/* Set the current fp rounding mode in the standard fp status and return WARNING: Block comments use a leading /* on a separate line #1585: FILE: target/arm/vfp_helper.c:479: + /* Squash FZ16 to 0 for the duration of conversion. In this case, WARNING: Block comments use a leading /* on a separate line #1598: FILE: target/arm/vfp_helper.c:492: + /* Squash FZ16 to 0 for the duration of conversion. In this case, WARNING: Block comments use a leading /* on a separate line #1611: FILE: target/arm/vfp_helper.c:505: + /* Squash FZ16 to 0 for the duration of conversion. In this case, WARNING: Block comments use a leading /* on a separate line #1624: FILE: target/arm/vfp_helper.c:518: + /* Squash FZ16 to 0 for the duration of conversion. In this case, WARNING: Block comments use a leading /* on a separate line #1669: FILE: target/arm/vfp_helper.c:563: +/* Constants 256 and 512 are used in some helpers; we avoid relying on WARNING: Block comments use a trailing */ on a separate line #1670: FILE: target/arm/vfp_helper.c:564: + * int->float conversions at run-time. */ WARNING: Block comments use a leading /* on a separate line #1677: FILE: target/arm/vfp_helper.c:571: +/* Reciprocal functions WARNING: Block comments use a leading /* on a separate line #1683: FILE: target/arm/vfp_helper.c:577: +/* See RecipEstimate() WARNING: Block comments use a leading /* on a separate line #1903: FILE: target/arm/vfp_helper.c:797: +/* The algorithm that must be used to calculate the estimate WARNING: Block comments use a leading /* on a separate line #1985: FILE: target/arm/vfp_helper.c:879: + /* Scale and normalize to a double-precision value between 0.25 and 1.0, WARNING: Block comments use a trailing */ on a separate line #1986: FILE: target/arm/vfp_helper.c:880: + * preserving the parity of the exponent. */ WARNING: Block comments use a leading /* on a separate line #2029: FILE: target/arm/vfp_helper.c:923: + /* Scale and normalize to a double-precision value between 0.25 and 1.0, WARNING: Block comments use a trailing */ on a separate line #2030: FILE: target/arm/vfp_helper.c:924: + * preserving the parity of the exponent. */ total: 21 errors, 20 warnings, 2164 lines checked Patch 2/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/8 Checking commit 0234b531feac (target/arm: Rearrange Floating-point data-processing (2 regs)) 4/8 Checking commit e6e668123e72 (target/arm: Implement ARMv8.3-JSConv) 5/8 Checking commit b188cbbcba44 (target/arm: Add helpers for FMLAL) 6/8 Checking commit 5f63a9cb31aa (target/arm: Implement FMLAL and FMLSL for aarch64) 7/8 Checking commit ad1df52ee03e (target/arm: Implement VFMAL and VFMSL for aarch32) 8/8 Checking commit 0ff65a844d2c (target/arm: Enable ARMv8.2-FHM for -cpu max) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190215192302.27855-1-richard.hender...@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
