On Fri, 15 Feb 2019 at 19:23, Richard Henderson <richard.hender...@linaro.org> wrote: > > > Changes since v3: > > Rebased on master, and combined the JSConv and FHM patch sets. > There were a number of patch conflicts which needed fixing up. > > Changes since v2: > > Patch 2 splits out vfp_helper.c, which I wrote for something else. > But while rebasing it occured to me that helper_vjcvt is better placed > in vfp_helper.c than op_helper.c, so why not include it here and now. > > Patch 3 corresponds to the v2 patch 1, but totally rewritten. What > I missed the first time around is that register Sn is encoded differenly > than Dn, so merely setting dp = 0 doesn't help because we've already > decoded the register number incorrectly. Therefore, replace some really > ugly if conditions and set some variables as appropriate. > > Patch 4 is adjusted to match the change in decode from patch 2, and > putting the aa32 flags in the right place.
I've applied patches 1-4 to target-arm.next; patches 5, 6, 8 I've commented on. 7 I'll leave until you've dealt with the fpstatus stuff in your next version of the patchset. thanks -- PMM