Patchew URL: https://patchew.org/QEMU/20190215192302.27855-1-richard.hender...@linaro.org/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190215192302.27855-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH v4 0/8] target/arm: Implement ARMv8.3-JSConv & ARMv8.2-FHM Type: series === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190123103323.4516-1-stefa...@redhat.com -> patchew/20190123103323.4516-1-stefa...@redhat.com * [new tag] patchew/20190215192302.27855-1-richard.hender...@linaro.org -> patchew/20190215192302.27855-1-richard.hender...@linaro.org Switched to a new branch 'test' 48aad41d17 target/arm: Enable ARMv8.2-FHM for -cpu max 386bd84229 target/arm: Implement VFMAL and VFMSL for aarch32 bd511444da target/arm: Implement FMLAL and FMLSL for aarch64 320923b415 target/arm: Add helpers for FMLAL 5f16dc5cd4 target/arm: Implement ARMv8.3-JSConv 4e880a6881 target/arm: Rearrange Floating-point data-processing (2 regs) ec64414896 target/arm: Split out vfp_helper.c 537337ef14 target/arm: Restructure disas_fp_int_conv === OUTPUT BEGIN === 1/8 Checking commit 537337ef142f (target/arm: Restructure disas_fp_int_conv) 2/8 Checking commit ec64414896da (target/arm: Split out vfp_helper.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #1101: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #1133: FILE: target/arm/vfp_helper.c:28: +/* VFP support. We follow the convention used for VFP instructions: WARNING: Block comments use * on subsequent lines #1134: FILE: target/arm/vfp_helper.c:29: +/* VFP support. We follow the convention used for VFP instructions: + Single precision routines have a "s" suffix, double precision a WARNING: Block comments use a trailing */ on a separate line #1135: FILE: target/arm/vfp_helper.c:30: + "d" suffix. */ ERROR: braces {} are necessary for all arms of this statement #1142: FILE: target/arm/vfp_helper.c:37: + if (host_bits & float_flag_invalid) [...] ERROR: braces {} are necessary for all arms of this statement #1144: FILE: target/arm/vfp_helper.c:39: + if (host_bits & float_flag_divbyzero) [...] ERROR: braces {} are necessary for all arms of this statement #1146: FILE: target/arm/vfp_helper.c:41: + if (host_bits & float_flag_overflow) [...] ERROR: braces {} are necessary for all arms of this statement #1148: FILE: target/arm/vfp_helper.c:43: + if (host_bits & (float_flag_underflow | float_flag_output_denormal)) [...] ERROR: braces {} are necessary for all arms of this statement #1150: FILE: target/arm/vfp_helper.c:45: + if (host_bits & float_flag_inexact) [...] ERROR: braces {} are necessary for all arms of this statement #1152: FILE: target/arm/vfp_helper.c:47: + if (host_bits & float_flag_input_denormal) [...] ERROR: braces {} are necessary for all arms of this statement #1188: FILE: target/arm/vfp_helper.c:83: + if (target_bits & 1) [...] ERROR: braces {} are necessary for all arms of this statement #1190: FILE: target/arm/vfp_helper.c:85: + if (target_bits & 2) [...] ERROR: braces {} are necessary for all arms of this statement #1192: FILE: target/arm/vfp_helper.c:87: + if (target_bits & 4) [...] ERROR: braces {} are necessary for all arms of this statement #1194: FILE: target/arm/vfp_helper.c:89: + if (target_bits & 8) [...] ERROR: braces {} are necessary for all arms of this statement #1196: FILE: target/arm/vfp_helper.c:91: + if (target_bits & 0x10) [...] ERROR: braces {} are necessary for all arms of this statement #1198: FILE: target/arm/vfp_helper.c:93: + if (target_bits & 0x80) [...] WARNING: Block comments use a leading /* on a separate line #1270: FILE: target/arm/vfp_helper.c:165: + /* The exception flags are ORed together when we read fpscr so we ERROR: space required after that ',' (ctx:VxV) #1285: FILE: target/arm/vfp_helper.c:180: +#define VFP_HELPER(name, p) HELPER(glue(glue(vfp_,name),p)) ^ ERROR: space required after that ',' (ctx:VxV) #1285: FILE: target/arm/vfp_helper.c:180: +#define VFP_HELPER(name, p) HELPER(glue(glue(vfp_,name),p)) ^ ERROR: Macros with multiple statements should be enclosed in a do - while loop #1287: FILE: target/arm/vfp_helper.c:182: +#define VFP_BINOP(name) \ +float32 VFP_HELPER(name, s)(float32 a, float32 b, void *fpstp) \ +{ \ + float_status *fpst = fpstp; \ + return float32_ ## name(a, b, fpst); \ +} \ +float64 VFP_HELPER(name, d)(float64 a, float64 b, void *fpstp) \ +{ \ + float_status *fpst = fpstp; \ + return float64_ ## name(a, b, fpst); \ +} ERROR: space prohibited before that close parenthesis ')' #1399: FILE: target/arm/vfp_helper.c:294: + CONV_FTOI(vfp_to##name##p, ftype, fsz, sign, ) \ ERROR: space prohibited before that close parenthesis ')' #1402: FILE: target/arm/vfp_helper.c:297: +FLOAT_CONVS(si, h, uint32_t, 16, ) ERROR: space prohibited before that close parenthesis ')' #1403: FILE: target/arm/vfp_helper.c:298: +FLOAT_CONVS(si, s, float32, 32, ) ERROR: space prohibited before that close parenthesis ')' #1404: FILE: target/arm/vfp_helper.c:299: +FLOAT_CONVS(si, d, float64, 64, ) ERROR: space prohibited before that close parenthesis ')' #1446: FILE: target/arm/vfp_helper.c:341: + get_float_rounding_mode(fpst), ) ERROR: space prohibited before that close parenthesis ')' #1451: FILE: target/arm/vfp_helper.c:346: + get_float_rounding_mode(fpst), ) WARNING: Block comments use a leading /* on a separate line #1551: FILE: target/arm/vfp_helper.c:446: +/* Set the current fp rounding mode and return the old one. WARNING: Block comments use a leading /* on a separate line #1564: FILE: target/arm/vfp_helper.c:459: +/* Set the current fp rounding mode in the standard fp status and return WARNING: Block comments use a leading /* on a separate line #1584: FILE: target/arm/vfp_helper.c:479: + /* Squash FZ16 to 0 for the duration of conversion. In this case, WARNING: Block comments use a leading /* on a separate line #1597: FILE: target/arm/vfp_helper.c:492: + /* Squash FZ16 to 0 for the duration of conversion. In this case, WARNING: Block comments use a leading /* on a separate line #1610: FILE: target/arm/vfp_helper.c:505: + /* Squash FZ16 to 0 for the duration of conversion. In this case, WARNING: Block comments use a leading /* on a separate line #1623: FILE: target/arm/vfp_helper.c:518: + /* Squash FZ16 to 0 for the duration of conversion. In this case, WARNING: Block comments use a leading /* on a separate line #1668: FILE: target/arm/vfp_helper.c:563: +/* Constants 256 and 512 are used in some helpers; we avoid relying on WARNING: Block comments use a trailing */ on a separate line #1669: FILE: target/arm/vfp_helper.c:564: + * int->float conversions at run-time. */ WARNING: Block comments use a leading /* on a separate line #1676: FILE: target/arm/vfp_helper.c:571: +/* Reciprocal functions WARNING: Block comments use a leading /* on a separate line #1682: FILE: target/arm/vfp_helper.c:577: +/* See RecipEstimate() WARNING: Block comments use a leading /* on a separate line #1902: FILE: target/arm/vfp_helper.c:797: +/* The algorithm that must be used to calculate the estimate WARNING: Block comments use a leading /* on a separate line #1984: FILE: target/arm/vfp_helper.c:879: + /* Scale and normalize to a double-precision value between 0.25 and 1.0, WARNING: Block comments use a trailing */ on a separate line #1985: FILE: target/arm/vfp_helper.c:880: + * preserving the parity of the exponent. */ WARNING: Block comments use a leading /* on a separate line #2028: FILE: target/arm/vfp_helper.c:923: + /* Scale and normalize to a double-precision value between 0.25 and 1.0, WARNING: Block comments use a trailing */ on a separate line #2029: FILE: target/arm/vfp_helper.c:924: + * preserving the parity of the exponent. */ total: 21 errors, 20 warnings, 2164 lines checked Patch 2/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/8 Checking commit 4e880a68817d (target/arm: Rearrange Floating-point data-processing (2 regs)) 4/8 Checking commit 5f16dc5cd4a4 (target/arm: Implement ARMv8.3-JSConv) 5/8 Checking commit 320923b41576 (target/arm: Add helpers for FMLAL) 6/8 Checking commit bd511444da88 (target/arm: Implement FMLAL and FMLSL for aarch64) 7/8 Checking commit 386bd8422967 (target/arm: Implement VFMAL and VFMSL for aarch32) 8/8 Checking commit 48aad41d17ed (target/arm: Enable ARMv8.2-FHM for -cpu max) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190215192302.27855-1-richard.hender...@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
