On 2018-11-21 11:34 a.m., Alistair Francis wrote: >> I don't understand what this patch actually accomplishes. It doesn't >> seem to affect my network devices when running QEMU. Can you provide a >> commit message explaining this? > > Could you connect a PCIe networking device without this commit? This > is what the other architectures all do as well. Yes, actually. Other architectures doing something is never a sufficient justification to make a change. I'm also not sure how virtio relates to this patch... I'd say unless you know you're fixing something specific and can describe it, you should drop this patch. Logan
- [Qemu-devel] [PATCH for-3.2 v7 0/6] Connect a PCIe host a... Alistair Francis
- [Qemu-devel] [PATCH for-3.2 v7 4/6] riscv: Enable VG... Alistair Francis
- Re: [Qemu-devel] [PATCH for-3.2 v7 4/6] riscv: E... Logan Gunthorpe
- [Qemu-devel] [PATCH for-3.2 v7 3/6] hw/riscv/virt: C... Alistair Francis
- Re: [Qemu-devel] [PATCH for-3.2 v7 3/6] hw/riscv... Logan Gunthorpe
- Re: [Qemu-devel] [PATCH for-3.2 v7 3/6] hw/r... Alistair Francis
- [Qemu-devel] [PATCH for-3.2 v7 6/6] hw/riscv/virt: C... Alistair Francis
- Re: [Qemu-devel] [PATCH for-3.2 v7 6/6] hw/riscv... Logan Gunthorpe
- Re: [Qemu-devel] [PATCH for-3.2 v7 6/6] hw/r... Alistair Francis
- Re: [Qemu-devel] [PATCH for-3.2 v7 6/6] ... Logan Gunthorpe
- Re: [Qemu-devel] [PATCH for-3.2 v7 ... Alistair Francis
- Re: [Qemu-devel] [PATCH for-3.2... Logan Gunthorpe
- Re: [Qemu-devel] [PATCH for... Alistair Francis
- Re: [Qemu-devel] [PATCH for... Alistair Francis
- Re: [Qemu-devel] [PATCH for... Logan Gunthorpe
- Re: [Qemu-devel] [PATCH for... Logan Gunthorpe
- [Qemu-devel] [PATCH for-3.2 v7 1/6] hw/riscv/virt: I... Alistair Francis
- Re: [Qemu-devel] [PATCH for-3.2 v7 1/6] hw/riscv... Logan Gunthorpe
- Re: [Qemu-devel] [PATCH for-3.2 v7 1/6] hw/r... Alistair Francis
- Re: [Qemu-devel] [PATCH for-3.2 v7 1/6] ... Logan Gunthorpe