On Wed, Nov 21, 2018 at 10:07 AM Logan Gunthorpe <log...@deltatee.com> wrote:
>
>
> On 2018-11-21 10:03 a.m., Alistair Francis wrote:
> > +    pci_bus = PCI_HOST_BRIDGE(dev)->bus;
> > +
> > +    for (i = 0; i < nb_nics; i++) {
> > +        NICInfo *nd = &nd_table[i];
> > +
> > +        if (!nd->model) {
> > +            nd->model = g_strdup("virtio");
> > +        }
> > +
> > +        pci_nic_init_nofail(nd, pci_bus, nd->model, NULL);
> > +    }
>
> I don't understand what this patch actually accomplishes. It doesn't
> seem to affect my network devices when running QEMU. Can you provide a
> commit message explaining this?

Could you connect a PCIe networking device without this commit? This
is what the other architectures all do as well.

I'll rejig the commit message/title to make this clearer.

Alistair

>
> Thanks,
>
> Logan

Reply via email to