On Wed, Nov 21, 2018 at 10:01 AM Logan Gunthorpe <log...@deltatee.com> wrote: > > > > On 2018-11-21 10:02 a.m., Alistair Francis wrote: > > Signed-off-by: Alistair Francis <alistair.fran...@wdc.com> > > Signed-off-by: Logan Gunthorpe <log...@deltatee.com> > > Reviewed-by: Logan Gunthorpe <log...@deltatee.com> > > > > diff --git a/default-configs/riscv32-softmmu.mak > > b/default-configs/riscv32-softmmu.mak > > index 7937c69e22..3e3d195f37 100644 > > --- a/default-configs/riscv32-softmmu.mak > > +++ b/default-configs/riscv32-softmmu.mak > > @@ -1,7 +1,11 @@ > > # Default configuration for riscv-softmmu > > > > +include pci.mak > > + > > CONFIG_SERIAL=y > > CONFIG_VIRTIO_MMIO=y > > -include virtio.mak > > > > CONFIG_CADENCE=y > > + > > +CONFIG_PCI_GENERIC=y > > +CONFIG_PCI_XILINX=y > > Nit: should PCI_XILINX not be in patch 5? It's not used in this patch > and was a bit confusing when reviewing.
It probably should be, I have moved it. Alistair > > Logan
