Eric Blake <ebl...@redhat.com> writes:
> On 08/08/2018 07:03 AM, Markus Armbruster wrote:
>> json-parser.c carefully reports end of input like this:
>>
>> token = parser_context_pop_token(ctxt);
>> if (token == NULL) {
>> parse_error(ctxt, NULL, "premature EOI");
>> goto out;
>> }
>
> Are the TABs in the commit message intentional?
No. Suspect a paste accident. Fixing...
>> Except parser_context_pop_token() can't return null, it fails its
>> assertion instead. Same for parser_context_peek_token(). Broken in
>> commit 65c0f1e9558, and faithfully preserved in commit 95385fe9ace.
>> Only a latent bug, because the streamer throws away any input that
>> could trigger it.
>>
>> Drop the assertions, so we can fix the streamer in the next commit.
>>
>> Signed-off-by: Markus Armbruster <arm...@redhat.com>
>> ---
>> qobject/json-parser.c | 2 --
>> 1 file changed, 2 deletions(-)
>
> Reviewed-by: Eric Blake <ebl...@redhat.com>
Thanks!
