On 08/08/2018 07:02 AM, Markus Armbruster wrote:
qmp-test is for QMP protocol tests. Commit e4a426e75ef added generic,
basic tests of query commands to it. Move them to their own test
program qmp-cmd-test, to keep qmp-test focused on the protocol.
Signed-off-by: Markus Armbruster <arm...@redhat.com>
---
MAINTAINERS | 1 +
tests/Makefile.include | 3 +
tests/qmp-cmd-test.c | 213 +++++++++++++++++++++++++++++++++++++++++
tests/qmp-test.c | 191 +-----------------------------------
4 files changed, 218 insertions(+), 190 deletions(-)
create mode 100644 tests/qmp-cmd-test.c
+++ b/tests/qmp-cmd-test.c
@@ -0,0 +1,213 @@
+/*
+ * QMP command test cases
+ *
+ * Copyright (c) 2017 Red Hat Inc.
Worth adding 2018?
+ *
+ * Authors:
+ * Markus Armbruster <arm...@redhat.com>,
+ *
Trailing comma is odd. And these days, I'm inclined to omit Author lines
(git history is more reliable, anyways)
Those are minor issues, where it is up to you if/how to clean them, so
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
