Re: [Qemu-devel] [PATCH v3 21/40] target/mips: Implement DSP ASE support for nanoMIPS

[Richard Henderson]

On 07/19/2018 05:54 AM, Stefan Markovic wrote:
> +        gen_helper_cmpgu_eq_qb(t1, v1_t, v2_t);
> +        tcg_gen_mov_tl(cpu_gpr[ret], t1);
> +        tcg_gen_andi_tl(cpu_dspctrl, cpu_dspctrl, 0xF0FFFFFF);
> +        tcg_gen_shli_tl(t1, t1, 24);
> +        tcg_gen_or_tl(cpu_dspctrl, cpu_dspctrl, t1);
Better as

  gen_helper_cmpgu_eq_qb(cpu_gpr[ret], v1_t, v2_t);
  tcg_gen_deposit_tl(cpu_dspctrl, cpu_dspctrl, cpu_gpr[ret], 24, 4);

and the several repetitions.


r~