On Fri, Dec 15, 2017 at 11:51:18AM +0100, Thomas Huth wrote: > On 15.12.2017 11:16, David Gibson wrote: > > Previously virtio-net was only tested for ppc64 in "slow" mode. That > > doesn't make much sense since virtio-net is used much more often in > > practice than the spapr-vlan device which was tested always. So, move > > virtio-net to always be tested on ppc64. > > Actually, I just moved virtio-net on ppc64 to the slow category a couple > of months ago: > > https://git.qemu.org/?p=qemu.git;a=commitdiff;h=ab06ec43577177a442e8e5 > > This has been done since some people complained that SLOF is incredibly > slow in in TCG mode and thus there is the risk of hitting the timeout on > slow systems if they are overloaded.
Hm. If we're really concerned about the speed, I'm more inclined to
move spapr-vlan to slow than virtio-net. virtio-net is now a much
more common case.
> Things will hopefully get a little bit better with the "Use
> tcg_gen_lookup_and_goto_ptr" patch that you've queued in your
> ppc-for-2.12 branch,
Just now merged, as it happens.
> but still, the test is very slow on ppc64, so I'd
> rather keep it in the "slow" category. (virtio-net is already tested in
> big endian mode on s390x anyway, so we at least got some endianess test
> coverage for that NIC already).
TBH, I see this as exercising the firmware netboot features more than
the device model.
>
> > We had no tests at all for the q35 machine, which doesn't seem wise given
> > it's increasing prominence. Add a couple of tests for it, including
> > testing the newer e1000e adapter.
>
> That sounds like a good idea! I wonder whether we should also test some
> "old" machine versions (in "slow" mode only, of course), like "pc-0.12"
> for example, to make sure that there are no regressions with old
> machines?
Maybe. Not really my department.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
