On Fri, Dec 15, 2017 at 12:10:56PM +0100, Thomas Huth wrote:
> On 15.12.2017 11:16, David Gibson wrote:
> > This adds IPv6 net boot testing (in addition to IPv4) when in slow test
> > mode on ppc64 or s390. IPv6 PXE doesn't seem to work on x86, I'm guessing
> > out BIOS image doesn't support it.
> >
> > Signed-off-by: David Gibson <da...@gibson.dropbear.id.au>
> > ---
> > tests/pxe-test.c | 26 ++++++++++++++++++++------
> > 1 file changed, 20 insertions(+), 6 deletions(-)
> [...]
> > } else if (strcmp(arch, "ppc64") == 0) {
> > - test_batch(ppc64_tests);
> > + test_batch(ppc64_tests, g_test_slow());
> > if (g_test_slow()) {
> > - test_batch(ppc64_tests_slow);
> > + test_batch(ppc64_tests_slow, true);
> > }
>
> The NICs from ppc64_tests_slow are now never exercised with IPv4 ...
> maybe it would be better to do both:
Yes they are: the ipv6 parameter to test_batch() makes it do IPv6
tests in addition to IPv4, unlike test_pxe_one() which just does one
or the other.
> test_batch(ppc64_tests_slow, false);
> test_batch(ppc64_tests_slow, true);
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
