On 15.12.2017 11:16, David Gibson wrote: > All of the x86 and some of the other test cases here use a common test > function, test_pxe_ipv4(), but one ppc and one s390 test use different > functions. > > In the s390 case, this is completely pointless, the right parameter to > test_pxe_ipv4() will already do exactly the right thing. For the > spapr-vlan case there's a slight difference - it will use IPv6 instead of > IPv4. > > But testing just one case with IPv6 (and NOT IPv4) is rather haphazard. > Change everything to use the common test function, until we have a better > way of testing IPv6 across the board. > > Signed-off-by: David Gibson <da...@gibson.dropbear.id.au> > --- > tests/pxe-test.c | 15 +++------------ > 1 file changed, 3 insertions(+), 12 deletions(-)
Reviewed-by: Thomas Huth <th...@redhat.com>