On 07.09.2017 05:16, Matthew Rosato wrote: > On 09/04/2017 11:43 AM, David Hildenbrand wrote: >> E.g. the following now works: >> device_add host-s390-cpu,id=cpu1,core-id=1 >> >> The system will perform the same checks as when using cpu_add: >> - If the core_id is already in use >> - If the next sequential core_id isn't used >> - If core-id >= max_cpu is specified >> >> In addition, mixed CPU models are checked. E.g. if starting with >> -cpu host and trying to hotplug "qemu-s390-cpu": >> "Mixed CPU models are not supported on s390x." >> >> Signed-off-by: David Hildenbrand <da...@redhat.com> > > As easy as flipping a switch, right?
Yes, luckily all that hotplug handling already was in place, just core-id vs. id had to be fixed. > > Tested the new device_add path, the old cpu-add path and mixed cases > where I alternated adding cpus via both methods -- looking good. > > Reviewed-by: Matthew Rosato <mjros...@linux.vnet.ibm.com> > Thanks! -- Thanks, David
