On Thu, 7 Sep 2017 14:46:44 +0200 David Hildenbrand <da...@redhat.com> wrote:
> >> +++ b/target/s390x/interrupt.c > >> @@ -15,6 +15,9 @@ > >> #include "exec/exec-all.h" > >> #include "sysemu/kvm.h" > >> #include "hw/s390x/ioinst.h" > >> +#if !defined(CONFIG_USER_ONLY) > >> +#include "hw/s390x/s390-virtio-ccw.h" > >> +#endif > >> > >> /* Ensure to exit the TB after this call! */ > >> void trigger_pgm_exception(CPUS390XState *env, uint32_t code, uint32_t > >> ilen) > >> > > > > If I listen to my gut feeling, I still think we should rather move > > s390_cpu_addr2state() to cpu.c instead. It does not sound as it's really > > specific to the virtio-ccw machine... Just my 0.02 € > > > > I prefer to leave it as is for now, so just a header cleanup. E.g. with > patch 18 we could implement it directly using ms->possible_cpus. If you do that, would you also get rid of the conditional include above?
