On Tue, 5 Sep 2017 14:52:44 +0200 Thomas Huth <th...@redhat.com> wrote:
> On 05.09.2017 14:46, Christian Borntraeger wrote: > > > > > > On 09/05/2017 02:42 PM, David Hildenbrand wrote: > >> On 05.09.2017 14:38, Cornelia Huck wrote: > >>> On Mon, 4 Sep 2017 17:43:05 +0200 > >>> David Hildenbrand <da...@redhat.com> wrote: > >>> > >>>> Fix up includes and rename it to s390x_*. > >>> > >>> I'm not quite sure whether that is the right direction: servc is just an > >>> instruction that does something and then happens to also generate an > >>> interrupt on conclusion. I'll think a bit more about it. > >>> > >> > >> Having CPU related stuff in sclp looks also wrong. Feel free to skip > >> this patch, should be unrelated to the following patches. > > > > I think having the sclp instruction handler in sclp (as today) is > > the best compromise. > > +1 > > But maybe you could at least move the prototype to sclp.h instead? That would be a good compromise.
