Markus Armbruster <arm...@redhat.com> writes: > "Dr. David Alan Gilbert" <dgilb...@redhat.com> writes: > >> * Markus Armbruster (arm...@redhat.com) wrote: >>> Cc: Juan Quintela <quint...@redhat.com> >>> Cc: Dr. David Alan Gilbert <dgilb...@redhat.com> >>> Signed-off-by: Markus Armbruster <arm...@redhat.com> >> >> >> Two thoughts: >> a) Do you actually want that as migration/migration.json? > > I'd prefer to keep the QAPI schema together. But that could be my > schema maintainer bias talking :) > >> b) I'd prefer StrOrNull to be somewhere more central; Migration may be >> the only user, but it's not logically migration specific. > > Makes sense. I'll move it to common.json.
Err, this patch already moves it there. >> Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com> > > Thanks!