Eric Blake <ebl...@redhat.com> writes: > On 08/24/2017 02:13 PM, Markus Armbruster wrote: >> Cc: "Daniel P. Berrange" <berra...@redhat.com> >> Cc: Alberto Garcia <be...@igalia.com> >> Cc: Dr. David Alan Gilbert <dgilb...@redhat.com> >> Cc: Gerd Hoffmann <kra...@redhat.com> >> Cc: Jason Wang <jasow...@redhat.com> >> Cc: Juan Quintela <quint...@redhat.com> >> Cc: Marc-André Lureau <marcandre.lur...@redhat.com> >> Cc: Paolo Bonzini <pbonz...@redhat.com> >> >> Much of the QAPI schema really belongs to a subsystem, but MAINTAINERS >> can't tell when it's all in a big ball of mud (qapi-schema.json) with >> a small ball of mud (event.json) on the side. >> >> Create sub-schemas for the subsystems with the most substantial QAPI >> footprint in the mud. The big ball shrinks by half, and the small >> ball goes away. >> >> Bonus: the generated documentation's structure makes more sense now. >> It needs further improvement (see last patch), but it's a start. >> >> I generally kept the order intact when moving source code. It may be >> smarter to reorder it for improved legibility (both source and >> generated doc). Subsystem maintainers, please tell me whether you'd >> like things reordered. > > Ideally, moving from one file to another should be kept separate from > reordering within a file, to make review easier.
I can move in order, then reorder in a separate patch, if that makes review easier. Reordering code is always awkward. It's just less awkward when we reshuffle things anyway.
