Hi, here's the new version of my patch series with misc fixes for the throttling code.
Stefan, once this is reviewed, can you please remove the "Make LeakyBucket.avg and LeakyBucket.max integer types" commit (id 218f470639117a8e39) from your block-next branch? This series contains a new version of that patch that replaces the one that you have. v2: - Patch 3: Make the code a bit more concise - Patch 5: LeakyBucket.avg and LeakyBucket.max are now unsigned - Patch 6: Make burst_length 64bit and check its range - Patch 7: Add unit tests v1: https://lists.gnu.org/archive/html/qemu-block/2017-08/msg00753.html - Initial version Output of backport-diff against v1: Key: [----] : patches are identical [####] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively 001/7:[----] [--] 'throttle: Fix wrong variable name in the header documentation' 002/7:[----] [--] 'throttle: Update the throttle_fix_bucket() documentation' 003/7:[down] 'throttle: Make throttle_is_valid() a bit less verbose' 004/7:[----] [--] 'throttle: Remove throttle_fix_bucket() / throttle_unfix_bucket()' 005/7:[0010] [FC] 'throttle: Make LeakyBucket.avg and LeakyBucket.max integer types' 006/7:[down] 'throttle: Make burst_length 64bit and add range checks' 007/7:[down] 'throttle: Test the valid range of config values' Alberto Garcia (7): throttle: Fix wrong variable name in the header documentation throttle: Update the throttle_fix_bucket() documentation throttle: Make throttle_is_valid() a bit less verbose throttle: Remove throttle_fix_bucket() / throttle_unfix_bucket() throttle: Make LeakyBucket.avg and LeakyBucket.max integer types throttle: Make burst_length 64bit and add range checks throttle: Test the valid range of config values include/qemu/throttle.h | 8 ++--- tests/test-throttle.c | 80 ++++++++++++++++++++++++++++++++++++++++++++- util/throttle.c | 86 +++++++++++++++++++------------------------------ 3 files changed, 117 insertions(+), 57 deletions(-) -- 2.11.0
