On Tue, Aug 22, 2017 at 01:48:15PM +0200, Cornelia Huck wrote: > On Tue, 22 Aug 2017 21:20:46 +1000 > David Gibson <da...@gibson.dropbear.id.au> wrote: > > > Obviously it's not a thing to fix right now, but I've really been > > thinking that none of the tests should use this "TCG or KVM" stuff. > > They should instead be run with *both* options - or at least the ones > > that are available on the host. > > Having one test as a 'smoke test' that is run for everything available > sounds like a good idea, and the boot-serial test may be a good > candidate for that. > > I would not want to run every test with every accelerator, however, as > this makes 'make check' even slower than it is now. (Although it may be > useful to be able to trigger 'run everything' tests on some dedicated > test machines.)
I'd be fine with only running the full matrix on a "make check-harder"
or whatever, target. But I'd like the option to be there. Sometimes
(like when preparing a pull request) a slower check is an acceptable
cost for better coverage.
> > That would have caught the bug in the pull request I sent you, and
> > would at least have given you a chance at seeing the problem with
> > boot-serial-test.
>
> I don't think that would have been caught unless you have the right
> host available... and given that most developers will only have a
> x86_64 machine and whatever other architecture they are working on (if
> any) available, they will run most of 'make check' with tcg only.
Sure, but running make check (amongst other things) on a ppc host is
part of my standard pre-pull-request tests, so it certainly would have
caught it in this case. Peter Maydell has said he has a ppc host
amongst his test systems. At the moment it doesn't do KVM so wouldn't
have caught the other problem, but it'd be one step closer to doing
so.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
