On 07/20/2017 04:37 AM, Jing Liu wrote: > Hi Cleber Rosa, > > > On 2017/7/19 上午5:22, Cleber Rosa wrote: >> >> On 07/18/2017 02:07 PM, John Snow wrote: >>> >>> On 07/17/2017 11:01 PM, Jing Liu wrote: >>> > [...] >> I see issues here: >> >> 1) The qemu-iotests "runner", that is, "./check", understands that a >> file number is a test. No further granularity is (currently?) >> achievable here. >> >> The easy solution would be to split tests which depend on optional >> features to separate test files. In the 087 test given as example, >> the "=== aio=native without O_DIRECT ===" block would become, say, 190. >> >> 2) Skip tests based on features more easily. There's already support >> for skipping tests on various situations. From 087: >> >> ... >> _supported_fmt qcow2 >> _supported_proto file >> _supported_os Linux >> ... >> >> It's trivial to also have access to other compile time settings. I did >> a quick experiment that would add a "_required_feature" function to >> "common.rc". > This seems a good way to solve this problem. > I failed for 087 just because there is no CONFIG_NETTLE_KDF. >
Good. This actually raises a question about requirements. I haven't checked thoroughly, but it looks like either gnutls or nettle can be used as crypto libraries. I'll take a better look at that. > I wonder how can common.rc detect if there's CONFIG_XXX in > config-host.mak ? > My experiment was based on a standalone tool that can be used like this: $ ./scripts/buildconf.py CONFIG_NETTLE_KDF False $ echo $? 255 And similarly, but considering a specific target configuration: $ ./scripts/buildconf.py CONFIG_MARVELL_88W8618 arm-softmmu True $ ./scripts/buildconf.py CONFIG_MARVELL_88W8618 x86_64-softmmu False And a 'common.rc' function that makes use of it. I also have use cases for doing something similar from Python code, so it should also be possible to use it as a (Python) module. - Cleber. > Thanks. > Jing >> For 087 (or 190?) it would look like: >> >> ... >> _supported_fmt qcow2 >> _supported_proto file >> _supported_os Linux >> _required_feature CONFIG_LINUX_AIO >> ... >> >> Does it make sense? Would a patch series along those lines would be >> welcomed by reviews? >> >> Thanks! >> > -- Cleber Rosa [ Sr Software Engineer - Virtualization Team - Red Hat ] [ Avocado Test Framework - avocado-framework.github.io ] [ 7ABB 96EB 8B46 B94D 5E0F E9BB 657E 8D33 A5F2 09F3 ]
signature.asc
Description: OpenPGP digital signature
