Hi Cleber Rosa,
On 2017/7/19 上午5:22, Cleber Rosa wrote:
On 07/18/2017 02:07 PM, John Snow wrote:
On 07/17/2017 11:01 PM, Jing Liu wrote:
[...]
I see issues here:
1) The qemu-iotests "runner", that is, "./check", understands that a
file number is a test. No further granularity is (currently?)
achievable here.
The easy solution would be to split tests which depend on optional
features to separate test files. In the 087 test given as example,
the "=== aio=native without O_DIRECT ===" block would become, say, 190.
2) Skip tests based on features more easily. There's already support
for skipping tests on various situations. From 087:
...
_supported_fmt qcow2
_supported_proto file
_supported_os Linux
...
It's trivial to also have access to other compile time settings. I did
a quick experiment that would add a "_required_feature" function to
"common.rc".
This seems a good way to solve this problem.
I failed for 087 just because there is no CONFIG_NETTLE_KDF.
I wonder how can common.rc detect if there's CONFIG_XXX in config-host.mak ?
Thanks.
Jing
For 087 (or 190?) it would look like:
...
_supported_fmt qcow2
_supported_proto file
_supported_os Linux
_required_feature CONFIG_LINUX_AIO
...
Does it make sense? Would a patch series along those lines would be
welcomed by reviews?
Thanks!
