On Wed, May 03, 2017 at 05:35:57PM -0300, Eduardo Habkost wrote: > fw_cfg won't work with -device, as: > * fw_cfg_init1() won't get called for the device; > * The device won't appear at /machine/fw_cfg, and won't work with > the -fw_cfg command-line option. > > Remove the user_creatable flag from the device class. > > Cc: Marcel Apfelbaum <mar...@redhat.com> > Cc: "Michael S. Tsirkin" <m...@redhat.com> > Cc: Laszlo Ersek <ler...@redhat.com> > Cc: Gabriel L. Somlo <so...@cmu.edu> > Reviewed-by: Laszlo Ersek <ler...@redhat.com> > Acked-by: Marcel Apfelbaum <mar...@redhat.com> > Signed-off-by: Eduardo Habkost <ehabk...@redhat.com>
Acked-by: Michael S. Tsirkin <m...@redhat.com> > --- > Changes v1 -> v2: > * (none) > --- > hw/nvram/fw_cfg.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c > index 7993aea792..316fca9bc1 100644 > --- a/hw/nvram/fw_cfg.c > +++ b/hw/nvram/fw_cfg.c > @@ -1101,11 +1101,6 @@ static void fw_cfg_io_class_init(ObjectClass *klass, > void *data) > > dc->realize = fw_cfg_io_realize; > dc->props = fw_cfg_io_properties; > - /* > - * FIXME: Set only because we are not sure yet if this device > - * will be outside the q35 sysbus whitelist. > - */ > - dc->user_creatable = true; > } > > static const TypeInfo fw_cfg_io_info = { > @@ -1172,11 +1167,6 @@ static void fw_cfg_mem_class_init(ObjectClass *klass, > void *data) > > dc->realize = fw_cfg_mem_realize; > dc->props = fw_cfg_mem_properties; > - /* > - * FIXME: Set only because we are not sure yet if this device > - * will be outside the q35 sysbus whitelist. > - */ > - dc->user_creatable = true; > } > > static const TypeInfo fw_cfg_mem_info = { > -- > 2.11.0.259.g40922b1