TYPE_S390_PCI_HOST_BRIDGE is a subclass of TYPE_PCI_HOST_BRIDGE,
which is a subclass of TYPE_SYS_BUS_DEVICE. TYPE_SYS_BUS_DEVICE
already sets user_creatable=false, so we don't require an
explicit user_creatable=false assignment in
s390_pcihost_class_init().
Cc: Alexander Graf <ag...@suse.de>
Cc: Christian Borntraeger <borntrae...@de.ibm.com>
Cc: Cornelia Huck <cornelia.h...@de.ibm.com>
Cc: Frank Blaschka <frank.blasc...@de.ibm.com>
Cc: Laszlo Ersek <ler...@redhat.com>
Cc: Marcel Apfelbaum <mar...@redhat.com>
Cc: Markus Armbruster <arm...@redhat.com>
Cc: Peter Maydell <peter.mayd...@linaro.org>
Cc: Pierre Morel <pmo...@linux.vnet.ibm.com>
Cc: Richard Henderson <r...@twiddle.net>
Cc: Thomas Huth <th...@redhat.com>
Cc: Yi Min Zhao <zyi...@linux.vnet.ibm.com>
Acked-by: Cornelia Huck <cornelia.h...@de.ibm.com>
Acked-by: Marcel Apfelbaum <mar...@redhat.com>
Signed-off-by: Eduardo Habkost <ehabk...@redhat.com>
---
Changes series v1 -> v2:
* Previous patch was:
"s390: Add FIXME for unexplained user_creatable=false line",
but now we know we can remove the explicit user_creatable=false
assignment
---
hw/s390x/s390-pci-bus.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
index b60a8f22b0..66a6fbeb8c 100644
--- a/hw/s390x/s390-pci-bus.c
+++ b/hw/s390x/s390-pci-bus.c
@@ -872,7 +872,6 @@ static void s390_pcihost_class_init(ObjectClass *klass,
void *data)
DeviceClass *dc = DEVICE_CLASS(klass);
HotplugHandlerClass *hc = HOTPLUG_HANDLER_CLASS(klass);
- dc->user_creatable = false;
dc->reset = s390_pcihost_reset;
k->init = s390_pcihost_init;
hc->plug = s390_pcihost_hot_plug;
--
2.11.0.259.g40922b1
