On Wed, May 03, 2017 at 05:36:02PM -0300, Eduardo Habkost wrote:
> virtio-mmio needs to be wired and mapped by other device or board
> code, and won't work with -device. Remove the user_creatable flag
> from the device class.
>
> Cc: Laszlo Ersek <ler...@redhat.com>
> Cc: Marcel Apfelbaum <mar...@redhat.com>
> Cc: Peter Maydell <peter.mayd...@linaro.org>
> Cc: Shannon Zhao <zhaoshengl...@huawei.com>
> Cc: "Michael S. Tsirkin" <m...@redhat.com>
> Reviewed-by: Laszlo Ersek <ler...@redhat.com>
> Acked-by: Marcel Apfelbaum <mar...@redhat.com>
> Signed-off-by: Eduardo Habkost <ehabk...@redhat.com>
Acked-by: Michael S. Tsirkin <m...@redhat.com>
> ---
> Changes v1 -> v2:
> * (none)
> ---
> hw/virtio/virtio-mmio.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c
> index 6491a771ff..5807aa87fe 100644
> --- a/hw/virtio/virtio-mmio.c
> +++ b/hw/virtio/virtio-mmio.c
> @@ -450,11 +450,6 @@ static void virtio_mmio_class_init(ObjectClass *klass,
> void *data)
> dc->reset = virtio_mmio_reset;
> set_bit(DEVICE_CATEGORY_MISC, dc->categories);
> dc->props = virtio_mmio_properties;
> - /*
> - * FIXME: Set only because we are not sure yet if this device
> - * will be outside the q35 sysbus whitelist.
> - */
> - dc->user_creatable = true;
> }
>
> static const TypeInfo virtio_mmio_info = {
> --
> 2.11.0.259.g40922b1
