On 25.04.2017 15:22, Eric Blake wrote: > On 04/25/2017 12:16 AM, Thomas Huth wrote: >> HMP commands do not get any automatic testing yet, so on certain >> QEMU machines, some HMP commands were causing crashes in the past. >> Thus we should test HMP commands in our test suite, too, to avoid >> that such problems creep in again in the future. >> >> Signed-off-by: Thomas Huth <th...@redhat.com> >> --- >> v3: >> - Fixed the stupid "!strcmp() == 0" problem > > That's why libvirt prefers the use of a STREQ() macro (it's easier to > read STREQ(a,b) than it is to remember if !strcmp(a,b) has the right > semantics). But switching the code base to use such a nice wrapper > would be a task for Coccinelle, if we wanted it.
I just saw that glib seems also to have a g_str_equal() function ... I guess we could use that in QEMU instead. I'll try to remember that for future code that I write ... Thomas
signature.asc
Description: OpenPGP digital signature
