On 04/25/2017 12:16 AM, Thomas Huth wrote: > HMP commands do not get any automatic testing yet, so on certain > QEMU machines, some HMP commands were causing crashes in the past. > Thus we should test HMP commands in our test suite, too, to avoid > that such problems creep in again in the future. > > Signed-off-by: Thomas Huth <th...@redhat.com> > --- > v3: > - Fixed the stupid "!strcmp() == 0" problem
That's why libvirt prefers the use of a STREQ() macro (it's easier to read STREQ(a,b) than it is to remember if !strcmp(a,b) has the right semantics). But switching the code base to use such a nice wrapper would be a task for Coccinelle, if we wanted it. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
