* Peter Maydell ([email protected]) wrote:
> On 24 April 2017 at 16:32, Dr. David Alan Gilbert (git)
> <[email protected]> wrote:
> > From: "Dr. David Alan Gilbert" <[email protected]>
> >
> > The following changes since commit 4c55b1d0bad8a703f0499fe62e3761a0cd288da3:
> >
> > Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2017-04-24'
> > into staging (2017-04-24 14:49:48 +0100)
> >
> > are available in the git repository at:
> >
> > git://github.com/dagrh/qemu.git tags/pull-hmp-20170424
> >
> > for you to fetch changes up to e4e3992e626c4cc7514b271807c90f587771c646:
> >
> > tests: Add a tester for HMP commands (2017-04-24 15:55:35 +0100)
> >
> > ----------------------------------------------------------------
> > HMP pull
> >
> > ----------------------------------------------------------------
>
>
> clang doesn't like some code in test-hmp.c:
>
> /home/petmay01/linaro/qemu-for-merges/tests/test-hmp.c:138:9: error:
> logical not is only applied to the left hand side of this comparison
> [-Werror,-Wlogical-not-parentheses]
> if (!strcmp("isapc", mname) == 0 || !strcmp("puv3", mname)
> ^ ~~
<snip>
> It does look rather odd:
>
> + /* Ignore blacklisted machines that have known problems */
> + if (!strcmp("isapc", mname) == 0 || !strcmp("puv3", mname)
> + || !strcmp("tricore_testboard", mname)
> + || !strcmp("xenfv", mname) == 0 || !strcmp("xenpv", mname)) {
> + return;
> + }
>
> since it's not using the same kind of expression to test
> each board name -- is that deliberate, or accidental ?
>
> I think this expression means we'll actually skip every machine...
Yep, you're right, just tried it with logging.
That's accidental; hmm I should add a clang build somewhere.
Thomas: Do you want to send me a fixed version?
Dave
> thanks
> -- PMM
--
Dr. David Alan Gilbert / [email protected] / Manchester, UK
