"Dr. David Alan Gilbert" <dgilb...@redhat.com> wrote:
> * Juan Quintela (quint...@redhat.com) wrote:
>> Rename it to preffer_xbzrle that is a more descriptive name.
>>
>> Signed-off-by: Juan Quintela <quint...@redhat.com>
>> ---
>> migration/ram.c | 9 +++++----
>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/migration/ram.c b/migration/ram.c
>> index 6a39704..591cf89 100644
>> --- a/migration/ram.c
>> +++ b/migration/ram.c
>> @@ -217,6 +217,9 @@ struct RAMState {
>> uint64_t dirty_pages_rate;
>> /* Count of requests incoming from destination */
>> uint64_t postcopy_requests;
>> + /* Should we move to xbzrle after the 1st round
>> + of compression */
>> + bool preffer_xbzrle;
>
> That's 'prefer' - however, do we need it at all?
> How about just replacing it by:
> !ram_bulk_stage && migrate_use_xbzrle()
>
> would that work?
Changed to that. I am not sure if that is simpler or more complex, but
it is clearly one less variable, so ....
Thanks, Juan.
