On 03/27/2017 08:26 AM, Markus Armbruster wrote: > This reverts half of commit 0a55679. We're having second thoughts on > the QAPI schema (and thus the external interface), and haven't reached > consensus, yet. Issues include: >
> Let's avoid painting ourselves into a corner now, and revert the > feature for 2.9. There may still be some tweaks to improve the commit message and/or code comments to clarify things that tripped me up until later in the subthread, but now that I understand the difference between pseudo-file format (where the key-value pair backdoor still works for libvirt's usage of -drive file=rbd:...) and QemuOpts format (-drive driver=rbd,... which didn't really exist in 2.8, and where we don't want to bake in something we don't like in 2.9), I agree with the move. > > Note that users can still configure authentication methods with a > configuration file. They probably do that anyway if they use Ceph > outside QEMU as well. > > qemu_rbd_array_opts()'s parameter @type now must be RBD_MON_HOST, > which is silly. This will be cleaned up shortly. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > block/rbd.c | 31 +++---------------------------- > qapi/block-core.json | 24 ------------------------ > 2 files changed, 3 insertions(+), 52 deletions(-) > Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
