Max Reitz <mre...@redhat.com> writes: > On 27.03.2017 15:26, Markus Armbruster wrote: >> The way we communicate extra key-value pairs from >> qemu_rbd_parse_filename() to qemu_rbd_open() exposes option parameter >> "keyvalue-pairs" on the command line. It's not wanted there. Hack: >> rename the parameter to "=keyvalue-pairs" to make it inaccessible. >> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> >> Reviewed-by: Eric Blake <ebl...@redhat.com> >> --- >> block/rbd.c | 12 ++++++++---- >> 1 file changed, 8 insertions(+), 4 deletions(-) > > Reviewed-by: Max Reitz <mre...@redhat.com>
Thanks! > (Or you could just use x- like blkdebug does...) Yes. An "x-" prefix tells you "don't use this", which you're free to ignore. The "=" prefix cannot be ignored, because the QemuOpts parser will choke on it. Matter of taste, I guess.
