On 17 February 2017 at 08:56, Paolo Bonzini <pbonz...@redhat.com> wrote: > So I do think that if musl wants to support _GNU_SOURCE, it should also > auto-define; > however it doesn't, see > https://git.musl-libc.org/cgit/musl/tree/include/features.h.
Yes, I agree that this looks like a musl bug. I spoke to a musl developer I happen to know, and he agreed to submit a patch to see what the other musl devs think. In the meantime, we should probably work around this system bug for the benefit of the existing musl installs in the field. Defining _XOPEN_SOURCE is easy enough, and I think we should do it unconditionally. We should check what effect this has on the BSD hosts though I guess. (You could argue that we should be defining _XOPEN_SOURCE anyway for the benefit of the non-glibc BSD/Solaris/etc platforms.) thanks -- PMM
