On 16 February 2017 at 16:30, Chad Joan <chadj...@gmail.com> wrote: > Hello, > > This is a one-line patch to the configure script that will allow QEMU to be > built on musl-libc based Linux systems. This problem is only noticeable > when QEMU is built with --enable-curses. > > Detailed reading material if you want to know where this came from: > https://bugs.gentoo.org/show_bug.cgi?id=609364
Thanks for the bug report and the patch. I'm a bit confused about why it's necessary, though. We already define _GNU_SOURCE, which the musl docs say implies _XOPEN_SOURCE: https://www.musl-libc.org/doc/1.0.0/manual.html Is that not true for your musl, or is our configure script failing to pass -D_GNU_SOURCE when building the curses test program? If we do need an explicit define of _XOPEN_SOURCE I think we should do it at the same place where we add -D_GNU_SOURCE to the cflags. thanks -- PMM
