On Tue, Nov 15, 2016 at 10:04:05AM +0800, Fam Zheng wrote: > On Mon, 11/14 13:06, Eric Blake wrote: > > So I guess you have to determine if libqnio is something that should > > compile completely independent from qemu, or whether it is so closely > > tied to the rest of qemu that it should follow qemu conventions. > > The question is on include directives in block/vxhs.c, not libnqio library > header, so qemu conventions apply.
Eric: The libqnio library header is not copied into the QEMU source tree. It is an external library dependency like libnfs or libglfs. Fam, Markus: Unfortunately neither the clean-includes script nor its patch series cover letter explains *why* osdep.h should be included before system headers. The libqnio header is self-contained (i.e. you can #include it and it has no dependencies) and only used by vxhs.c. Why is it a good idea to include qemu/osdep.h first? Seems like a bad idea to me because it masks missing dependencies in the libqnio header. Stefan
signature.asc
Description: PGP signature
