On Wed, Nov 16, 2016 at 9:49 AM, Fam Zheng <f...@redhat.com> wrote: > On Wed, 11/16 10:04, Markus Armbruster wrote: >> ashish mittal <ashmit...@gmail.com> writes: >> >> > Thanks for concluding on this. >> > >> > I will rearrange the qnio_api.h header accordingly as follows: >> > >> > +#include "qemu/osdep.h" >> >> Headers should not include osdep.h. > > This is about including "osdep.h" _and_ "qnio_api.h" in block/vxhs.c, so what > Ashish means looks good to me.
Yes, I think "will rearrange the qnio_api.h header" was a typo and was supposed to be block/vxhs.c. Stefan