That makes perfect sense. I will try and follow this method now onwards. Thanks!
On Wed, Sep 28, 2016 at 7:18 PM, Jeff Cody <jc...@redhat.com> wrote: > On Tue, Sep 27, 2016 at 09:09:49PM -0700, Ashish Mittal wrote: >> This patch adds support for a new block device type called "vxhs". >> Source code for the library that this code loads can be downloaded from: >> https://github.com/MittalAshish/libqnio.git >> >> Sample command line using JSON syntax: >> ./qemu-system-x86_64 -name instance-00000008 -S -vnc 0.0.0.0:0 -k en-us -vga >> cirrus -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x5 -msg >> timestamp=on >> 'json:{"driver":"vxhs","vdisk_id":"{c3e9095a-a5ee-4dce-afeb-2a59fb387410}","server":[{"host":"172.172.17.4","port":"9999"},{"host":"172.172.17.2","port":"9999"}]}' >> >> Sample command line using URI syntax: >> qemu-img convert -f raw -O raw -n >> /var/lib/nova/instances/_base/0c5eacd5ebea5ed914b6a3e7b18f1ce734c386ad >> vxhs://192.168.0.1:9999/%7Bc6718f6b-0401-441d-a8c3-1f0064d75ee0%7D >> >> Signed-off-by: Ashish Mittal <ashish.mit...@veritas.com> > > Hi Ashish, > > You've received a lot of feedback to digest on your patch -- creating a > whole new block driver can be difficult! > > If I may make a suggestion: it is usually more productive to address the > feedback via email _before_ you code up and send out the next patch version, > unless the comments are straightforward and don't need any discussion (many > comments often don't). > > For instance, I appreciate your reply to the feedback on v6, but by the time > it hit my inbox v7 was already there, so it more or less kills the > discussion and starts the review cycle afresh. Not a big deal, but overall > it would probably be more productive if that reply was sent first, and we > could discuss things like sleep, coroutines, caching, global ctx instances, > etc... :) Those discussion might then help shape the next patch even more, > and result in fewer iterations. > > > Thanks, and happy hacking! > -Jeff
