On Fri, Apr 15, 2016 at 08:32:54AM +0530, Prerna Saxena wrote:
> diff --git a/block/block-backend.c b/block/block-backend.c
> index d74f670..0aa8692 100644
> --- a/block/block-backend.c
> +++ b/block/block-backend.c
> @@ -407,6 +407,7 @@ BlockBackend *blk_by_legacy_dinfo(DriveInfo *dinfo)
> return blk;
> }
> }
> + error_report("Drive Info not found, Aborting.");
error_report() documentation says:
* Format arguments like sprintf(). The resulting message should be a
* single phrase, with no newline or trailing punctuation.
> abort();
> }
>
> @@ -463,6 +464,8 @@ int blk_attach_dev(BlockBackend *blk, void *dev)
> void blk_attach_dev_nofail(BlockBackend *blk, void *dev)
> {
> if (blk_attach_dev(blk, dev) < 0) {
> + error_report("Attaching device model to block %s failed. Aborting",
Please use '%s' instead of just %s for consistency with other error
messages.
> + blk->name);
> abort();
> }
> }
> @@ -1143,6 +1146,7 @@ BlockErrorAction blk_get_error_action(BlockBackend
> *blk, bool is_read,
> case BLOCKDEV_ON_ERROR_IGNORE:
> return BLOCK_ERROR_ACTION_IGNORE;
> default:
> + error_report("Unrecognized Block Error Action %d. Aborting.",on_err);
s/,/, /
Please use scripts/checkpatch.pl to check for coding style violations.
> diff --git a/exec.c b/exec.c
> index c4f9036..1b1d713 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -2218,6 +2218,7 @@ static MemTxResult subpage_read(void *opaque, hwaddr
> addr, uint64_t *data,
> *data = ldq_p(buf);
> return MEMTX_OK;
> default:
> + printf("Unsupported read size %d, Aborting", len);
Why use printf() instead of error_report() in this file?
signature.asc
Description: PGP signature
