On Fri, Apr 15, 2016 at 08:32:53AM +0530, Prerna Saxena wrote:
> Commit 43dc2a64 replaced assert() with abort(), but didnt remove statements
> that followed these calls. So current code still has return values set after
> a call to abort(). Such statements will never execute and need to be cleaned
> up.
>
> Signed-off-by: Prerna Saxena <saxenap....@nutanix.com>
> ---
> block/vvfat.c | 17 +++--------------
> 1 file changed, 3 insertions(+), 14 deletions(-)
>
> diff --git a/block/vvfat.c b/block/vvfat.c
> index 6b85314..ffe739b 100644
> --- a/block/vvfat.c
> +++ b/block/vvfat.c
> @@ -1747,8 +1747,7 @@ static uint32_t
> get_cluster_count_for_direntry(BDRVVVFATState* s,
> schedule_new_file(s, g_strdup(path), cluster_num);
> else {
> abort();
> - return 0;
> - }
> + }
The following change breaks indentation:
^Ielse {
...
-^I}
+^I }
Since the else statement only has a single tab character it's wrong to
have mixed tabs and spaces for the closing curly.
Please resend this patch with tab-only indentation. The diff hunks
below sometimes introduce spaces.
signature.asc
Description: PGP signature
