Hi, Leon, There is one more subtle point here. The question is: Where to put declarations of two new functions? This is a new case in the organization of mips-specific source code files. File helpers.h does not seem to be a good place, cpu.h - maybe, but still looks clumsy to me.
IMHO, my solution from earlier versions of this patch series, in spite of containing code duplication, is superior in the sense of keeping current mips-specific source code file relations intact, respecting autonomy of msa_helpers.c, and is the best overall. Yours, Aleksandar ________________________________________ From: Leon Alrae Sent: Friday, April 15, 2016 3:41 AM To: Aleksandar Markovic; Aleksandar Markovic; qemu-devel@nongnu.org Cc: pro...@gmail.com; kbast...@mail.uni-paderborn.de; mark.cave-ayl...@ilande.co.uk; ag...@suse.de; blauwir...@gmail.com; jcmvb...@gmail.com; qemu-...@nongnu.org; qemu-...@nongnu.org; Petar Jovanovic; pbonz...@redhat.com; Miodrag Dinic; edgar.igles...@gmail.com; g...@mprc.pku.edu.cn; afaer...@suse.de; aurel...@aurel32.net; r...@twiddle.net; Maciej Rozycki Subject: Re: [PATCH v4 1/9] softfloat: Implement run-time-configurable meaning of signaling NaN bit On 15/04/16 09:48, Aleksandar Markovic wrote: > Agreed. This looks much better, and is simpler and faster. Though, it looks > to me that "fst" should be called "status" instead (just not to break > consistency throughout SoftFloat library and in other places of assigning > name "status" to the last argument of any function if its type is > float_status*). If you agree, I am going to replace name "fst" with name > "status" in the code that you provided, otherwise as-is. Yes, "status" will be fine. Leon
