On 11/12/2015 01:23 AM, Markus Armbruster wrote: > Eric Blake <ebl...@redhat.com> writes: > >> Our documentation states that we prefer 'lower-case', rather than >> 'CamelCase', for qapi enum values. The InputButton and InputAxis >> enums violated this convention. However, they are currently used >> primarily for generating code that is used internally; their only >> exposure through QMP is via the experimental 'x-input-send-event' >> command. Since this is experimental, changing the QMP wire format >> for that command is acceptable.
> > I can take this through my tree if Gerd doesn't object. If we aren't changing the spelling of x-, then we shouldn't change the spelling of the arguments to x-. How about this instead: add a FIXME comment to qapi-schema.json that documents that the names of the enum values will likely be changed at the (later) point where x- is removed. In the meantime, if we add any namespace enforcing, we'll just have to whitelist these two. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
