Now that we have introspection, we should consider what we are exposing to the end user, and try to avoid spurious changes in future versions. There has been debate about switching the qapi code generator to produce different output for 'CamelCase' enum values; the easiest way to ensure this doesn't bite us in later releases is to rename the QMP spellings now in a way that doesn't impact the C spelling. Promoting the experimental command to supported will be the easiest way to learn about the switch in spelling.
This isn't quite a bug fix, and it won't hurt us if we delay to 2.6 (the command remains expermental for one more release). But delaying will let the churn show up in introspection results, so I'm arguing that it would be nice to get this series into 2.5; even though any proposed changes to the generator won't go into effect until 2.6. Eric Blake (2): input: Avoid CamelCase in InputEvent enums input: Promote 'input-send-event' to stable API qapi-schema.json | 14 ++++++-------- qmp-commands.hx | 24 +++++++++++------------- ui/input.c | 4 ++-- 3 files changed, 19 insertions(+), 23 deletions(-) -- 2.4.3
