On 7 November 2015 at 15:25, Andrew Jones <drjo...@redhat.com> wrote:
> Signed-off-by: Andrew Jones <drjo...@redhat.com>
> ---
> hw/arm/virt.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 77d9267599b7e..9c6792cea16f6 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -941,8 +941,8 @@ static void machvirt_init(MachineState *machine)
> if (!gic_version) {
> gic_version = kvm_arm_vgic_probe();
> if (!gic_version) {
> - error_report("Unable to determine GIC version supported by
> host\n"
> - "Probably KVM acceleration is not supported\n");
> + error_report("Unable to determine GIC version supported by
> host");
> + error_printf("KVM acceleration is probably not supported\n");
> exit(1);
> }
> }
> @@ -990,7 +990,7 @@ static void machvirt_init(MachineState *machine)
> char *cpuopts = g_strdup(cpustr[1]);
>
> if (!oc) {
> - fprintf(stderr, "Unable to find CPU definition\n");
> + error_report("Unable to find CPU definition");
> exit(1);
> }
> cpuobj = object_new(object_class_get_name(oc));
> @@ -1126,8 +1126,8 @@ static void virt_set_gic_version(Object *obj, const
> char *value, Error **errp)
> } else if (!strcmp(value, "host")) {
> vms->gic_version = 0; /* Will probe later */
> } else {
> - error_report("Invalid gic-version option value\n"
> - "Allowed values are: 3, 2, host\n");
> + error_report("Invalid gic-version option value");
> + error_printf("Allowed gic-version values are: 3, 2, host\n");
> exit(1);
> }
Would it be better just to have a single error_report
for these without the newlines, eg
error_report("Unable to determine GIC version supported by host. "
"KVM acceleration is probably not supported.");
?
thanks
-- PMM
