On 03/04/2015 07:09 AM, zhanghailiang wrote: > The original 'status' is an open-coded 'str' type, convert it to use an > enum type. > This conversion is backwards compatible, better documented and > more convenient for future extensibility. > > We also rename 'MIGRATION_STATUS_ERROR' to 'MIGRATION_STATUS_FAILED'.
I argue that this change should be done in 1/4. > In addition, Fix a typo for qapi-schema.json: comppleted -> completed but this one can stay here. > > Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> > --- > hmp.c | 7 ++++--- > migration/migration.c | 34 ++++++++++++---------------------- > qapi-schema.json | 34 +++++++++++++++++++++++++++++----- > 3 files changed, 45 insertions(+), 30 deletions(-) > Otherwise, modulo Markus' review, it's looking better. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
