Am 02.05.2014 16:33, schrieb Paolo Bonzini:
> SIPI interrupts are ignored on the bootstrap. Never accept one.
>
> Cc: Andreas Färber <afaer...@suse.de>
> Cc: Michael S. Tsirkin <m...@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
> ---
> hw/intc/apic_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c
> index 7ecce2d..05c0e08 100644
> --- a/hw/intc/apic_common.c
> +++ b/hw/intc/apic_common.c
> @@ -200,7 +200,7 @@ void apic_init_reset(DeviceState *dev)
> s->initial_count = 0;
> s->initial_count_load_time = 0;
> s->next_time = 0;
> - s->wait_for_sipi = 1;
> + s->wait_for_sipi = !cpu_is_bsp(s->cpu);
I wondered whether this will work on hot-add. I believe so, since the
device is reset on realized=true after executing the realize hook, and
the APIC gets realized as part of the CPU (but before it's reset).
Reviewed-by: Andreas Färber <afaer...@suse.de>
Andreas
>
> if (s->timer) {
> timer_del(s->timer);
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
