Luiz Capitulino writes: > On Wed, 07 May 2014 19:07:56 +0200 > Lluís Vilanova <vilan...@ac.upc.edu> wrote:
>> Luiz Capitulino writes: >> >> > On Mon, 5 May 2014 14:21:26 -0400 >> > Luiz Capitulino <lcapitul...@redhat.com> wrote: >> >> >> On Fri, 2 May 2014 15:52:19 +0200 >> >> Lluís Vilanova <vilan...@ac.upc.edu> wrote: >> >> >> >> > Adds an include primitive to the syntax of QAPI schema files, allowing >> >> > these to >> >> > be modularized into multiple per-topic files in the future. >> >> > >> >> > Signed-off-by: Lluís Vilanova <vilan...@ac.upc.edu> >> >> > Reviewed-by: Eric Blake <ebl...@redhat.com> >> >> > Reviewed-by: Markus Armbruster <arm...@redhat.com> >> >> >> >> Applied to the qmp branch, thanks. >> >> > make check fails for me: >> >> > TEST tests/qapi-schema/include-before-err.out >> > Files >> > /home/lcapitulino/work/src/upstream/qmp-unstable/tests/qapi-schema/include-before-err.err >> > and - differ >> > make: *** [check-tests/qapi-schema/include-before-err.json] Error 1 >> >> Sorry, it's my fault. I though I did rerun the tests. The change is: >> >> sed -i -e 's/after/before' tests/qapi-schema/include-before-err.err >> >> Should I resend the series? > It would be nice if you can resend only the affected patch. You mean resend a fixed version of the original patch, or a patch on top of the series? Thanks, Lluis -- "And it's much the same thing with knowledge, for whenever you learn something new, the whole world becomes that much richer." -- The Princess of Pure Reason, as told by Norton Juster in The Phantom Tollbooth
